more renamings of acronyms to camelCase#10153
Merged
erik-krogh merged 4 commits intogithub:mainfrom Aug 26, 2022
Merged
Conversation
javascript/ql/experimental/adaptivethreatmodeling/modelbuilding/evaluation/NosqlInjectionATM.ql
Fixed
Show fixed
Hide fixed
...ipt/ql/experimental/adaptivethreatmodeling/modelbuilding/evaluation/NosqlInjectionATMLite.ql
Fixed
Show fixed
Hide fixed
...cript/ql/experimental/adaptivethreatmodeling/modelbuilding/evaluation/SqlInjectionATMLite.ql
Fixed
Show fixed
Hide fixed
javascript/ql/experimental/adaptivethreatmodeling/modelbuilding/evaluation/SqlInjectionATM.ql
Fixed
Show fixed
Hide fixed
javascript/ql/experimental/adaptivethreatmodeling/modelbuilding/evaluation/TaintedPathATM.ql
Fixed
Show fixed
Hide fixed
...script/ql/experimental/adaptivethreatmodeling/modelbuilding/evaluation/TaintedPathATMLite.ql
Fixed
Show fixed
Hide fixed
javascript/ql/experimental/adaptivethreatmodeling/modelbuilding/evaluation/XssATM.ql
Fixed
Show fixed
Hide fixed
javascript/ql/experimental/adaptivethreatmodeling/modelbuilding/evaluation/XssATMLite.ql
Fixed
Show fixed
Hide fixed
9f93021 to
1e01bcf
Compare
| SALElement() { | ||
| containsSALAnnotation(this.(DeclarationEntry).getFile()) or | ||
| this instanceof SALAnnotation | ||
| library class SalElement extends Element { |
Check warning
Code scanning / CodeQL
Use of deprecated annotation
|
|
||
| library class JAXBElement extends Class { | ||
| JAXBElement() { | ||
| library class JaxbElement extends Class { |
Check warning
Code scanning / CodeQL
Use of deprecated annotation
| /** DEPRECATED: Alias for JaxbElement */ | ||
| deprecated class JAXBElement = JaxbElement; | ||
|
|
||
| library class JaxbMarshalMethod extends Method { |
Check warning
Code scanning / CodeQL
Use of deprecated annotation
| * * `result` would be `"multipart test"` | ||
| */ | ||
| private DataFlow::Node getSMTPSubscriptByIndex(DataFlow::CallCfgNode sendCall, string index) { | ||
| private DataFlow::Node getSmtpSubscriptByIndex(DataFlow::CallCfgNode sendCall, string index) { |
Check warning
Code scanning / CodeQL
Missing QLDoc for parameter
107e808 to
255f6e3
Compare
3659094 to
7edf851
Compare
5 tasks
7edf851 to
1d1aa7c
Compare
aschackmull
approved these changes
Aug 26, 2022
RasmusWL
approved these changes
Aug 26, 2022
Comment on lines
+34
to
+36
|
|
||
| /** DEPRECATED: Alias for missingAnnotationOnSink */ | ||
| deprecated predicate missingAnnotationOnSINK = missingAnnotationOnSink/3; |
Member
There was a problem hiding this comment.
This is just a test-file, so we can just do the rename without deprecation 😊
Suggested change
| /** DEPRECATED: Alias for missingAnnotationOnSink */ | |
| deprecated predicate missingAnnotationOnSINK = missingAnnotationOnSink/3; |
Contributor
Author
There was a problem hiding this comment.
I'll delete the deprecation with my deprecation-deletion-script in 14+ months anyway.
And I don't want to run the tests again, and bump the submodule pointer again, so I'll let this one stay.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
One last round of renaming acronyms to follow our style guide. I'm not planning any more renamings of upper-case acronyms after this.
The change-notes from last time still work.
The tests fail, but there is an internal PR where they pass.